Skip to content

Conversation

@JAORMX
Copy link
Collaborator

@JAORMX JAORMX commented Nov 17, 2025

The actual type is type: "tool" not tool_call.

pkg/vmcp/composer/composer.go:	// StepTypeTool executes a backend tool.
pkg/vmcp/composer/composer.go:	StepTypeTool StepType = "tool"

So this fixes this erroneous reference.

Signed-off-by: Juan Antonio Osorio ozz@stacklok.com

The actual type is `type: "tool"` not `tool_call`.

```
pkg/vmcp/composer/composer.go:	// StepTypeTool executes a backend tool.
pkg/vmcp/composer/composer.go:	StepTypeTool StepType = "tool"
```

So this fixes this erroneous reference.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested review from jhrozek and yrobla November 17, 2025 13:39
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.84%. Comparing base (8ce0337) to head (38d5f70).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lpha1/virtualmcpcompositetooldefinition_webhook.go 50.00% 1 Missing ⚠️
...-operator/api/v1alpha1/virtualmcpserver_webhook.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2608   +/-   ##
=======================================
  Coverage   55.84%   55.84%           
=======================================
  Files         312      312           
  Lines       29541    29541           
=======================================
+ Hits        16496    16498    +2     
+ Misses      11603    11601    -2     
  Partials     1442     1442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
yrobla
yrobla previously approved these changes Nov 17, 2025
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX merged commit 107ea07 into main Nov 17, 2025
32 checks passed
@JAORMX JAORMX deleted the fix-tool-call branch November 17, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants