Add Path and Shape #123
Merged
Add Path and Shape #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackotter
requested changes
Apr 27, 2025
Owner
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Sorry for taking a while to get around to this.
Thanks so much for getting this to where it is, it's looking great. I've just left a few small change requests but they're mostly formatting, naming and documentation (which were all great for the most part).
I'll test this out locally in a bit more depth once I've finished off my assignment due soon. I'm probably gonna try making a graphing example with bar charts, line charts and pie charts to stress test everything.
stackotter
approved these changes
May 9, 2025
Owner
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Looks good now, thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not currently implemented in GtkBackend or Gtk3Backend, but I may be able to do the former in the near future