Skip to content

fixes #09 16h #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

fixes #09 16h #10

merged 2 commits into from
Feb 3, 2025

Conversation

cdsiats
Copy link
Contributor

@cdsiats cdsiats commented Feb 1, 2025 •
edited
Loading

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue Negative Values #9
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

cblanquera
cblanquera requested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello make sure to include a test whenever changes are made especially in a core library.

@cdsiats cdsiats requested a review from cblanquera February 1, 2025 09:28
@cblanquera cblanquera merged commit b66fdee into stackpress:main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblanquera cblanquera cblanquera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdsiats @cblanquera