Skip to content

fix(ROX-15587): expose metrics on different port to rest of server#1222

Merged
tommartensen merged 3 commits intomasterfrom
tm/metrics-port
Mar 12, 2024
Merged

fix(ROX-15587): expose metrics on different port to rest of server#1222
tommartensen merged 3 commits intomasterfrom
tm/metrics-port

Conversation

@tommartensen
Copy link
Copy Markdown
Contributor

@tommartensen tommartensen commented Mar 12, 2024

Moved metrics to a different port, so they aren't world-readable anymore.

Verify with the cluster linked in the comment below:

@tommartensen tommartensen self-assigned this Mar 12, 2024
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 12, 2024

A single node development cluster (infra-pr-1222) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.9.5-3-g98485b949c to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1222 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen tommartensen changed the title wip: fix: expose metrics on different port to rest of server fix(ROX-15587): expose metrics on different port to rest of server Mar 12, 2024
@tommartensen tommartensen marked this pull request as ready for review March 12, 2024 13:36
@tommartensen tommartensen requested a review from a team as a code owner March 12, 2024 13:36
@BradLugo
Copy link
Copy Markdown
Contributor

Thanks for taking care of this!

@tommartensen tommartensen merged commit a0e9821 into master Mar 12, 2024
@tommartensen tommartensen deleted the tm/metrics-port branch March 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants