Skip to content

fix: get only the most recent tag in Makefile#1269

Merged
BradLugo merged 1 commit intomasterfrom
blugo/fix-git-tagged
Apr 22, 2024
Merged

fix: get only the most recent tag in Makefile#1269
BradLugo merged 1 commit intomasterfrom
blugo/fix-git-tagged

Conversation

@BradLugo
Copy link
Copy Markdown
Contributor

@BradLugo BradLugo commented Apr 19, 2024

Description

When multiple tags are associated with the current commit, the TAGGED variable in the Makefile will contain more than one tag. Any time we use this variable, we assume that there is only one tag.

These changes explicitly get the most recent tag and only one tag associated with the current commit.

Slack thread: https://redhat-internal.slack.com/archives/C04KV7S8KHV/p1713466775971019

@BradLugo BradLugo self-assigned this Apr 19, 2024
@BradLugo BradLugo requested a review from a team as a code owner April 19, 2024 19:37
@rhacs-bot
Copy link
Copy Markdown
Contributor

A single node development cluster (infra-pr-1269) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.9.37-1-gf2cca7b710 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1269 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

Copy link
Copy Markdown
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BradLugo BradLugo merged commit 20598a7 into master Apr 22, 2024
@BradLugo BradLugo deleted the blugo/fix-git-tagged branch April 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants