- 
                Notifications
    
You must be signed in to change notification settings  - Fork 258
 
Fix: pdb-min-available when Replica number is controlled via HPA #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the pdb validation without hpa
* feat: creates an HPA Map Object to avoid nested for * chore: rm unused code
* feat: creates an HPA Map Object to avoid nested for * chore: rm unused code * fix: map inicialization size * fix: bool check error
| 
           @janisz, giving an update: @jvtartaglia helped a lot in refining the code to avoid nested   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one last comment about supported versions.
Also if you like it will be great to have a e2e test for that with different autoscaling version .e.g: that will pass on this PR
---
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: baz
  namespace: bar
spec:
  minAvailable: 1
  selector:
    matchLabels:
      name: example
---
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
  name: app
  namespace: bar
spec:
  minReplicas: 4
  maxReplicas: 100
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: foo
    namespace: bar
  targetCPUUtilizationPercentage: 85
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo
  namespace: bar
spec:
  selector:
    matchLabels:
      name: example
  template:
    metadata:
      labels:
        name: example| 
           @jpedrobf Thank you!  | 
    
I believe this solves #637.
The commit history might be a little messy but it was made with heart 💚