ROX-21124: Move release branch jobs from OSCI to GHA #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradLugo
force-pushed
the
blugo/ROX-21124-GHA-for-release-branches
branch
from
fe094c3 to
2f1911f
Compare
RTann
reviewed
Jan 23, 2024
Contributor
RTann
left a comment
RTann
left a comment
There was a problem hiding this comment.
I don't think we want to run diff-dumps in release-* branches. Just master and PR with the generate-dumps-on-pr label.
We also want to run upload-dumps-for-downstream upon tag (would that be in a separate PR?)
| push: | ||
| branches: | ||
| - master | ||
| - 'release-*' |
Contributor
There was a problem hiding this comment.
I think we may need to run these things upon tag creation, too? Not sure how to convert the OSCI release process into GHA release
BradLugo
force-pushed
the
blugo/ROX-21124-GHA-for-release-branches
branch
from
2f1911f to
e2b90fd
Compare
BradLugo
force-pushed
the
blugo/ROX-21124-GHA-for-release-branches
branch
from
e2b90fd to
208fe6b
Compare
dcaravel
reviewed
Jun 25, 2024
dcaravel
approved these changes
Jun 26, 2024
Contributor
dcaravel
left a comment
dcaravel
left a comment
There was a problem hiding this comment.
LGTM.
Regarding testing - assuming since some of the jobs only run on merge to master will have to monitor the runs to ensure no issues.
BradLugo
added a commit
that referenced
this pull request
Jun 27, 2024
BradLugo
added a commit
that referenced
this pull request
Jun 27, 2024
BradLugo
added a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes enable GitHub Action workflows for jobs that were previously running in OSCI. Once merged, any new tags containing these changes will have OSCI configs that look more like master's than the other release branch OSCI configs.
Note for reviewers: here's the OSCI config that gates certain jobs from running in certain contexts: https://github.com/stackrox/scanner/blob/master/scripts/ci/gate-jobs-config.json. We should generally try to follow this for now unless we see a compelling reason not to.