build: Add CPU limits to scanner builds #2293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://www.github.com/konflux-ci/build-definitions/pull/2856. The one is going to re-introduce explicit
limits.cpuon all tasks. It may be useful to set our limits.cpu where missing.Related thread https://redhat-internal.slack.com/archives/C04F4NE15U1/p1759320578511439
I actually don't know what's going to happen when their
limits.cpuwill be less than ourrequests.cpuif we don't apply this change.I tried simulating it locally with #2294 which is most likely what's going to happen once their values are combined with ours and saw this in UI
The task's pod did not even get started and I could not find it in
kubectl get podsoutput.Here's what came in
kubectl events:Validation
Only CI. Checked that amd64 buildah duration did not become longer than other platforms.