ROX-31317: disable mintmaker auto-approvals for release branches #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommartensen
commented
Oct 21, 2025
|
@tommartensen: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
msugakov
reviewed
Oct 21, 2025
Contributor
msugakov
left a comment
msugakov
left a comment
There was a problem hiding this comment.
Looks good. I've a couple of suggestions
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
msugakov
approved these changes
Oct 22, 2025
tommartensen
deleted the
tm/ROX-31317-disable-mintmaker-auto-merges-for-release-branches
branch
5 tasks
tommartensen
added a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
tommartensen
added a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
tommartensen
added a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/ROX-31317 for context.
I tested in my test environment: https://github.com/tommartensen/test-gh-actions/blob/master/.github/workflows/auto-merge.yaml