-
Notifications
You must be signed in to change notification settings - Fork 168
ROX-12637: make kuttl tests tolerate pause reconcile status condition #17023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test gke-operator-e2e-tests |
|
Images are ready for the commit at a4ca604. To use with deploy scripts, first |
e39dee9 to
e5a571e
Compare
|
/test gke-operator-e2e-tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17023 +/- ##
========================================
Coverage 48.80% 48.80%
========================================
Files 2696 2706 +10
Lines 201493 202086 +593
========================================
+ Hits 98331 98625 +294
- Misses 95400 95695 +295
- Partials 7762 7766 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit e5a571e.
|
/test all |
d42d299 to
258c5a1
Compare
|
/test all |
|
/retest |
|
Caution There are some errors in your PipelineRun template.
|
Description
TODO:
The pause-reconcile support is upstream as of March 2025 (operator-framework/helm-operator-plugins#426). It includes the
Pausedcondition instatus.So we need to teach our tests to tolerate it before we rebase our helm-operator fork.
The problem is kudobuilder/kuttl#76 but it is possible to work it around by using the recently added CEL support. Here I'm changing only the places which are exposed to a status of a CR reconciled by any "old" version of the ACS operator, because the regular CEL-free way is more readable and any failures are also reported in a nicer way.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI