Skip to content

Conversation

@dashrews78
Copy link
Contributor

the beginning of the end of old model

deleting stuff

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@dashrews78
Copy link
Contributor Author

dashrews78 commented Oct 6, 2025

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 6, 2025

Images are ready for the commit at 279b227.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-239-g279b22748c.

@dashrews78 dashrews78 force-pushed the dashrews/cve-model-cleanup-stuff-28123 branch 7 times, most recently from e91f4c1 to 5b05ac3 Compare October 16, 2025 10:09
@dashrews78 dashrews78 force-pushed the dashrews/cve-model-cleanup-stuff-28123 branch 7 times, most recently from b223d4f to e59f969 Compare October 27, 2025 10:10
@dashrews78 dashrews78 force-pushed the dashrews/cve-model-cleanup-stuff-28123 branch 4 times, most recently from 8b2c7c6 to 3a3e612 Compare October 29, 2025 16:15
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 53.87205% with 137 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.34%. Comparing base (071f40e) to head (7048c56).

Files with missing lines Patch % Lines
central/graphql/resolvers/image_vulnerabilities.go 50.00% 44 Missing and 6 partials ⚠️
central/cve/converter/utils/convert_utils.go 0.00% 27 Missing ⚠️
central/graphql/resolvers/image_cve_core.go 0.00% 19 Missing ⚠️
central/graphql/resolvers/image_components.go 76.78% 9 Missing and 4 partials ⚠️
central/graphql/resolvers/resolver.go 0.00% 8 Missing ⚠️
central/graphql/resolvers/search.go 87.23% 2 Missing and 4 partials ⚠️
...entral/graphql/resolvers/vulnerability_requests.go 0.00% 5 Missing ⚠️
central/image/datastore/store/v2/postgres/store.go 76.92% 2 Missing and 1 partial ⚠️
central/config/service/service.go 0.00% 2 Missing ⚠️
...graphql/resolvers/plotted_image_vulnerabilities.go 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17147      +/-   ##
==========================================
+ Coverage   48.72%   49.34%   +0.62%     
==========================================
  Files        2728     2679      -49     
  Lines      203123   197994    -5129     
==========================================
- Hits        98973    97707    -1266     
+ Misses      96402    92673    -3729     
+ Partials     7748     7614     -134     
Flag Coverage Δ
go-unit-tests 49.34% <53.87%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashrews78 dashrews78 force-pushed the dashrews/cve-model-cleanup-stuff-28123 branch 3 times, most recently from 2e8ec44 to cd0e556 Compare October 31, 2025 10:45
@dashrews78 dashrews78 changed the title ROX-28123: purge old CVE model code [DO NOT REVIEW] ROX-28123: purge old CVE model code Oct 31, 2025
@dashrews78 dashrews78 force-pushed the dashrews/cve-model-cleanup-stuff-28123 branch from 8dc4c8c to 279b227 Compare October 31, 2025 18:54
@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2025

@dashrews78: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-operator-e2e-tests 279b227 link false /test gke-operator-e2e-tests
ci/prow/ocp-4-19-operator-e2e-tests 279b227 link false /test ocp-4-19-operator-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 279b227 link false /test ocp-4-12-operator-e2e-tests
ci/prow/gke-qa-e2e-tests 279b227 link false /test gke-qa-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests 279b227 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-19-qa-e2e-tests 279b227 link false /test ocp-4-19-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants