This repository was archived by the owner on Aug 1, 2023. It is now read-only.
fix "Module not found" #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54
The problem was the package.json
binentry script was pointing to the compiled js inlib/which isn't committed to the repo, and the post-install build script is not ran in certain environments.This PR changes the
binscript to load the *.ts files directly viats-node, rather than depending on post-install scripts to behave consistently across different environments.Testing
Test using an installation of nodejs from official packages and not from nvm -- these installation methods seem to cause a difference in how global package install scripts are ran.
Using
npmglobal install on MacOS/Linux:Using
npmglobal install on Windows:Using
npx:Using
yarnglobal install:Reviewer note
PR includes minor type fixes required after updating to latest
typescriptlib.