Address #2228: update reward cycle duration in SIP-007 #2230
Conversation
sip/sip-007-stacking-consensus.md
Outdated
| period `x` less than 12000 blocks, then the signed message is only valid for | ||
| Stacking participation for `floor(x / 1000)` reward cycles (the minimum | ||
| participation length is one cycle: 1000 blocks). | ||
| These signed messages are valid for at most 12 reward cycles (24000 Bitcoin |
There was a problem hiding this comment.
Reward cycles are 2100 blocks long. This is 25200 blocks.
There was a problem hiding this comment.
I'm going by the convention in the original text: when the cycle was 1000 blocks, prepare phase was 240 blocks I believe. So technically original text should have used cycle length of 1240 blocks. However, my understanding is that prepare phase of the next cycle overlaps with the reward phase of the current cycle, so the "effective" cycle length was 1000 previously, and should be 2000 now.
Happy to change the convention once @kantai confirms.
There was a problem hiding this comment.
The reward phase and prepare phase no longer overlap -- which means that each "cycle" is 2100 blocks. While the "effective" reward phase is 2000 blocks, the maximum length of a lockup is 12 * 2100 Stacks blocks (25,200).
There was a problem hiding this comment.
Yeah, I figured with prepare phase being PoB for #1805 they can no longer overlap. Will update, thanks!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.