chore: wip

Author: chrisbbreuer

bun.lock

@@ -16,7 +16,6 @@ import {
 // Laravel-style Job Classes
 class SendEmailNotification extends JobBase implements ShouldQueue, ShouldBeUnique {
   public connection = 'redis'
-  public queue!: Queue<any>
   public tries = 3
   public timeout = 30 // seconds
   public backoff = [5, 10, 30] // seconds
@@ -62,7 +61,6 @@ class SendEmailNotification extends JobBase implements ShouldQueue, ShouldBeUniq
 
 class ProcessPayment extends JobBase implements ShouldQueue, ShouldBeUnique {
   public connection = 'priority'
-  public queue!: Queue<any>
   public tries = 5
   public timeout = 60 // seconds
   public backoff = [1, 5, 15, 30, 60] // seconds
@@ -114,7 +112,6 @@ class ProcessPayment extends JobBase implements ShouldQueue, ShouldBeUnique {
 
 class GenerateMonthlyReport extends JobBase implements ShouldQueue, ShouldBatch {
   public connection = 'redis'
-  public queue!: Queue<any>
   public tries = 2
   public timeout = 120 // seconds
   public batchId?: string

examples/proper-laravel-api.ts

@@ -10,7 +10,6 @@ import {
 
 // Laravel-style Job
 class WelcomeEmailJob extends JobBase implements ShouldQueue {
-  public queue!: Queue<any>
   public tries = 3
 
   constructor(private email: string, private name: string) {

examples/unified-config-demo.ts

@@ -63,6 +63,8 @@
   },
   "devDependencies": {
     "@stacksjs/docs": "^0.70.23",
+    "@stacksjs/eslint-config": "^4.14.0-beta.3",
+    "@types/bun": "^1.3.0",
     "better-dx": "^0.1.4"
   },
   "overrides": {

package.json

@@ -219,7 +219,11 @@ export class JobBatch implements Batch {
       if (this.options?.onConnection)
         jobClone.connection = this.options.onConnection
 
-      return jobClone.dispatch?.()
+      const dispatchResult = await jobClone.dispatch?.()
+      if (!dispatchResult) {
+        throw new Error('Job dispatch method not implemented or returned undefined')
+      }
+      return dispatchResult
     })
 
     const dispatchedJobs = await Promise.all(jobPromises)

packages/bun-queue/src/dispatch.ts

@@ -38,7 +38,7 @@ export class RedisFailedJobProvider implements FailedJobProvider {
     }
 
     // In a real implementation, store in Redis
-    console.log(`[FailedJobProvider] Logged failed job ${id} from queue ${queue}`)
+    console.log(`[FailedJobProvider] Logged failed job ${id} from queue ${_queue}`)
 
     return id
   }

packages/bun-queue/src/failed/failed-job-provider.ts

@@ -107,10 +107,7 @@ export class UniqueJobMiddleware implements JobMiddleware {
 
     try {
       // Try to set a lock key with NX (only if not exists) and EX (expiration)
-      const lockAcquired = await redisClient.set(key, '1', {
-        NX: true,
-        EX: this.ttl,
-      })
+      const lockAcquired = await redisClient.send('SET', [key, '1', 'NX', 'EX', this.ttl.toString()])
 
       if (!lockAcquired) {
         // Job with this unique ID is already queued/processing
@@ -217,10 +214,7 @@ export class WithoutOverlappingMiddleware implements JobMiddleware {
 
     try {
       // Try to acquire a lock
-      const lockAcquired = await redisClient.set(key, Date.now().toString(), {
-        NX: true,
-        EX: this.ttl,
-      })
+      const lockAcquired = await redisClient.send('SET', [key, Date.now().toString(), 'NX', 'EX', this.ttl.toString()])
 
       if (!lockAcquired) {
         // Another instance of this job is already running

packages/bun-queue/src/middleware.ts

@@ -6,6 +6,7 @@
     "module": "esnext",
     "moduleResolution": "bundler",
     "resolveJsonModule": true,
+    "types": ["bun"],
     "allowImportingTsExtensions": true,
     "strict": true,
     "strictNullChecks": true,