chore: wip

Author: chrisbbreuer

src/md.ts

@@ -1,7 +1,8 @@
 import { md5 } from './algorithms/hash/md5'
 import { sha1 } from './algorithms/hash/sha1'
 import { sha256 } from './algorithms/hash/sha256'
-import { sha384, sha512 } from './algorithms/hash/sha512'
+import { sha384 } from './algorithms/hash/sha384'
+import { sha512 } from './algorithms/hash/sha512'
 
 export interface MessageDigest {
   sha1: typeof sha1

src/utils/index.ts

@@ -545,26 +545,27 @@ export class ByteStringBuffer {
   }
 }
 
+// Create an alias for ByteStringBuffer for backward compatibility
 export const ByteBuffer: typeof ByteStringBuffer = ByteStringBuffer
 
-// Utility functions
-
 /**
- * Creates a buffer that stores bytes.
+ * Creates a new byte buffer.
+ *
+ * @param [input] the input to create the byte buffer from.
+ * @param [encoding] optional encoding ('utf8' or 'binary').
  *
- * @param [input] a string with encoded bytes to store in the buffer.
- * @param [encoding] (default: 'raw', other: 'utf8').
+ * @return the byte buffer.
  */
 export function createBuffer(input?: string, encoding?: string): ByteStringBuffer {
-  encoding = encoding || 'raw'
-
   if (input !== undefined && encoding === 'utf8') {
     input = encodeUtf8(input)
   }
 
   return new ByteStringBuffer(input)
 }
 
+// Utility functions
+
 /**
  * Checks if the given object is an ArrayBuffer.
  *

test/unit/sha1.test.ts

@@ -0,0 +1,62 @@
+import { describe, it, expect } from 'bun:test'
+import { fillString } from '../../src/utils'
+import { sha1 } from '../../src/algorithms/hash/sha1'
+
+describe('sha1', () => {
+  it('should have correct digest length', () => {
+    const md = sha1.create()
+    expect(md.digestLength).toBe(20)
+  })
+
+  it('should digest the empty string', () => {
+    const md = sha1.create()
+    expect(md.digest().toHex()).toBe('da39a3ee5e6b4b0d3255bfef95601890afd80709')
+  })
+
+  it('should digest "abc"', () => {
+    const md = sha1.create()
+    md.update('abc')
+    expect(md.digest().toHex()).toBe('a9993e364706816aba3e25717850c26c9cd0d89d')
+  })
+
+  it('should digest "The quick brown fox jumps over the lazy dog"', () => {
+    const md = sha1.create()
+    md.update('The quick brown fox jumps over the lazy dog')
+    expect(md.digest().toHex()).toBe('2fd4e1c67a2d28fced849ee1bb76e7391b93eb12')
+  })
+
+  it('should digest "c\'\u00E8"', () => {
+    const md = sha1.create()
+    md.update('c\'\u00E8', 'utf8')
+    expect(md.digest().toHex()).toBe('98c9a3f804daa73b68a5660d032499a447350c0d')
+  })
+
+  it('should digest "THIS IS A MESSAGE"', () => {
+    const md = sha1.create()
+    md.start()
+    md.update('THIS IS ')
+    md.update('A MESSAGE')
+    // do twice to check continuing digest
+    expect(md.digest().toHex()).toBe('5f24f4d6499fd2d44df6c6e94be8b14a796c071d')
+    expect(md.digest().toHex()).toBe('5f24f4d6499fd2d44df6c6e94be8b14a796c071d')
+  })
+
+  it('should digest a long message', () => {
+    // Note: might be too slow on old browsers
+    const md = sha1.create()
+    md.update(fillString('a', 1000000))
+    expect(md.digest().toHex()).toBe('34aa973cd4c4daa4f61eeb2bdbad27316534016f')
+  })
+
+  it('should digest multiple long messages', () => {
+    // Note: might be too slow on old browsers
+    // done multiple times to check hot loop optimizations
+    for (let loop = 0; loop < 3; ++loop) {
+      const md = sha1.create()
+      for (let i = 0; i < 10000; ++i) {
+        md.update('abc')
+      }
+      expect(md.digest().toHex()).toBe('a838edb5dec47b84b4bfb0a528ea958a5d9d2350')
+    }
+  })
+})