Skip to content

Commit f05f79f

Browse files
author
Arthur Cinader
committed
Add remove() to ionic.modal.IonicModalController
Per api: http://ionicframework.com/docs/api/controller/ionicModal/ note the note in the ionic source code: "Be sure to call [remove()](#remove) when you are done with each modal to clean it up and avoid memory leaks." https://github.com/driftyco/ionic/blob/af1bfef327e685585244c6051c4d38b98aa6c62a/js/angular/service/modal.js#L87
1 parent 78ba6e4 commit f05f79f

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

ionic/ionic-tests.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ class IonicTestController {
149149
ionicModalController.initialize(modalOptions);
150150
ionicModalController.show().then(() => console.log("shown modal"))
151151
ionicModalController.hide().then(() => console.log("hid modal"))
152+
ionicModalController.remove().then(() => console.log("removed modal"))
152153
var isShown: boolean = ionicModalController.isShown();
153154

154155
this.$ionicModal.fromTemplateUrl("templateUrl", modalOptions)

ionic/ionic.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ declare module ionic {
174174
initialize(options: IonicModalOptions): void;
175175
show(): ng.IPromise<void>;
176176
hide(): ng.IPromise<void>;
177+
remove(): ng.IPromise<void>;
177178
isShown(): boolean;
178179
}
179180

0 commit comments

Comments
 (0)