Skip to content

removed unneeded "else" statements #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2014
Merged

removed unneeded "else" statements #63

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34367b6
removed unneeded "else" statements
yaroslavya Jan 16, 2014
e76a10f
removed the trailing spaces in mode function
yaroslavya Jan 25, 2014
f64010f
removed trailing spaces in the empty lines in mode function.
yaroslavya Jan 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions stacktrace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,21 @@
mode: function(e) {
if (e['arguments'] && e.stack) {
return 'chrome';
} else if (e.stack && e.sourceURL) {
}

if (e.stack && e.sourceURL) {
return 'safari';
} else if (e.stack && e.number) {
}

if (e.stack && e.number) {
return 'ie';
} else if (e.stack && e.fileName) {
}

if (e.stack && e.fileName) {
return 'firefox';
} else if (e.message && e['opera#sourceloc']) {
}

if (e.message && e['opera#sourceloc']) {
// e.message.indexOf("Backtrace:") > -1 -> opera9
// 'opera#sourceloc' in e -> opera9, opera10a
// !e.stacktrace -> opera9
Expand All @@ -86,18 +94,23 @@
return 'opera9'; // use e.message
}
return 'opera10a'; // use e.stacktrace
} else if (e.message && e.stack && e.stacktrace) {
}

if (e.message && e.stack && e.stacktrace) {
// e.stacktrace && e.stack -> opera10b
if (e.stacktrace.indexOf("called from line") < 0) {
return 'opera10b'; // use e.stacktrace, format differs from 'opera10a'
}
// e.stacktrace && e.stack -> opera11
return 'opera11'; // use e.stacktrace, format differs from 'opera10a', 'opera10b'
} else if (e.stack && !e.fileName) {
}

if (e.stack && !e.fileName) {
// Chrome 27 does not have e.arguments as earlier versions,
// but still does not have e.fileName as Firefox
return 'chrome';
}

return 'other';
},

Expand Down