Merge pull request #641 from testwill/close_body

MuneebAijaz · web-flow · commit 24bb264c5ae5 · 2024-04-24T14:44:28.000+05:00
fix: close resp body
diff --git a/internal/pkg/handler/upgrade.go b/internal/pkg/handler/upgrade.go
@@ -133,6 +133,7 @@ func sendWebhook(url string) (string, []error) {
 		// the reloader seems to retry automatically so no retry logic added
 		return "", err
 	}
+	defer resp.Body.Close()
 	var buffer bytes.Buffer
 	_, bufferErr := io.Copy(&buffer, resp.Body)
 	if bufferErr != nil {

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ func sendWebhook(url string) (string, []error) {`
`133`	`133`	`// the reloader seems to retry automatically so no retry logic added`
`134`	`134`	`return "", err`
`135`	`135`	`}`
	`136`	`+ defer resp.Body.Close()`
`136`	`137`	`var buffer bytes.Buffer`
`137`	`138`	`_, bufferErr := io.Copy(&buffer, resp.Body)`
`138`	`139`	`if bufferErr != nil {`