Skip to content

Commit 8ebbb47

Browse files
committed
Added logs on startup & get ns opration
1 parent 9263b81 commit 8ebbb47

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

internal/pkg/cmd/reloader.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,10 @@ func startReloader(cmd *cobra.Command, args []string) {
138138
logrus.Fatal(err)
139139
}
140140

141+
if len(namespaceLabelSelector) > 0 {
142+
logrus.Warnf("namespace-selector is set, will detect changes in namespaces with these labels: %s.", namespaceLabelSelector)
143+
}
144+
141145
collectors := metrics.SetupPrometheusEndpoint()
142146

143147
var controllers []*controller.Controller

internal/pkg/controller/controller.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,15 +104,25 @@ func (c *Controller) resourceInNamespaceSelector(raw interface{}) bool {
104104

105105
switch object := raw.(type) {
106106
case *v1.ConfigMap:
107-
namespace, _ := c.client.CoreV1().Namespaces().Get(context.Background(), object.ObjectMeta.Namespace, metav1.GetOptions{})
107+
namespace, err := c.client.CoreV1().Namespaces().Get(context.Background(), object.ObjectMeta.Namespace, metav1.GetOptions{})
108+
if err != nil {
109+
logrus.Warn(err)
110+
return false
111+
}
112+
108113
for selectorKey, selectorVal := range c.namespaceSelector {
109114
namespaceLabelVal, namespaceLabelKeyExists := namespace.ObjectMeta.Labels[selectorKey]
110115
if !namespaceLabelKeyExists || selectorVal != namespaceLabelVal {
111116
return false
112117
}
113118
}
114119
case *v1.Secret:
115-
namespace, _ := c.client.CoreV1().Namespaces().Get(context.Background(), object.ObjectMeta.Namespace, metav1.GetOptions{})
120+
namespace, err := c.client.CoreV1().Namespaces().Get(context.Background(), object.ObjectMeta.Namespace, metav1.GetOptions{})
121+
if err != nil {
122+
logrus.Warn(err)
123+
return false
124+
}
125+
116126
for selectorKey, selectorVal := range c.namespaceSelector {
117127
namespaceLabelVal, namespaceLabelKeyExists := namespace.ObjectMeta.Labels[selectorKey]
118128
if !namespaceLabelKeyExists || selectorVal != namespaceLabelVal {

0 commit comments

Comments
 (0)