-
-
Notifications
You must be signed in to change notification settings - Fork 77
Feature/263 cmdstanr harmonize #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #277 +/- ##
===========================================
+ Coverage 75.89% 78.37% +2.47%
===========================================
Files 9 9
Lines 2199 2562 +363
===========================================
+ Hits 1669 2008 +339
- Misses 530 554 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi @ahartikainen - need your review - this change should make things work more smoothly w/ saving inference data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/notebooks/MCMC Sampling.ipynb
Outdated
"\n", | ||
"import pandas as pd\n", | ||
"y_sums_pd = pd.DataFrame(data=y_sums)\n", | ||
"y_sums.plot.hist(range(0,N+1))" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, I usually use matplotlib.pyplot as plt
--> plt.hist(y_syms, bins=range(0,N+1))
I think using the norm. But nothing needs to be changed here.
Submission Checklist
Summary
Deprecate CmdStanMCMC object properties
warmup
andsample
and introducemethod
draws(inc_warmup: bool = False)
.Update docs.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: