Skip to content

Conversation

mitzimorris
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Deprecate CmdStanMCMC object properties warmup and sample and introduce
method draws(inc_warmup: bool = False).

Update docs.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.37%. Comparing base (d758170) to head (b0e2e97).
⚠️ Report is 1408 commits behind head on develop.

Files with missing lines Patch % Lines
cmdstanpy/stanfit.py 98.36% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
+ Coverage    75.89%   78.37%   +2.47%     
===========================================
  Files            9        9              
  Lines         2199     2562     +363     
===========================================
+ Hits          1669     2008     +339     
- Misses         530      554      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mitzimorris
Copy link
Member Author

hi @ahartikainen - need your review - this change should make things work more smoothly w/ saving inference data.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"\n",
"import pandas as pd\n",
"y_sums_pd = pd.DataFrame(data=y_sums)\n",
"y_sums.plot.hist(range(0,N+1))"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, I usually use matplotlib.pyplot as plt --> plt.hist(y_syms, bins=range(0,N+1))

I think using the norm. But nothing needs to be changed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants