Skip to content

Have each Rev test cleanup memory after running #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2025
Merged

Have each Rev test cleanup memory after running #3246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd4af2f
use AGradRev so that all tests clean themselves up in the rev testing…
SteveBronder Oct 7, 2025
29ea240
Merge commit '407dcfeb7bcdc5cbea1ff427e4945161fc47a276' into HEAD
yashikno Oct 7, 2025
40920f5
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 7, 2025
1ca4162
fix cpplint
SteveBronder Oct 7, 2025
28c7048
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions test/unit/math/rev/core/accumulate_adjoints_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
#include <gtest/gtest.h>
#include <stan/math/rev/core.hpp>
#include <stan/math.hpp>
#include <test/unit/math/rev/util.hpp>
#include <vector>

TEST(AgradRev_accumulate_adjoints, zero_args) {
TEST_F(AgradRev, Rev_accumulate_adjoints_zero_args) {
Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
double* ptr = stan::math::accumulate_adjoints(storage.data());

Expand All @@ -14,7 +15,7 @@ TEST(AgradRev_accumulate_adjoints, zero_args) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, int_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_int_arg) {
int arg = 5;
Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);

Expand All @@ -27,7 +28,7 @@ TEST(AgradRev_accumulate_adjoints, int_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, double_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_double_arg) {
double arg = 5.0;

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -40,7 +41,7 @@ TEST(AgradRev_accumulate_adjoints, double_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, std_vector_int_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_int_arg) {
std::vector<int> arg(5, 10);

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -53,7 +54,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_int_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, std_vector_double_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_double_arg) {
std::vector<double> arg(5, 10.0);

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -66,7 +67,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_double_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, eigen_vector_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_eigen_vector_arg) {
Eigen::VectorXd arg = Eigen::VectorXd::Ones(5);

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -78,7 +79,7 @@ TEST(AgradRev_accumulate_adjoints, eigen_vector_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, eigen_row_vector_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_eigen_row_vector_arg) {
Eigen::RowVectorXd arg = Eigen::RowVectorXd::Ones(5);

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -91,7 +92,7 @@ TEST(AgradRev_accumulate_adjoints, eigen_row_vector_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, eigen_matrix_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_eigen_matrix_arg) {
Eigen::MatrixXd arg = Eigen::MatrixXd::Ones(5, 5);

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -104,7 +105,7 @@ TEST(AgradRev_accumulate_adjoints, eigen_matrix_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, std_vector_std_vector_double_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_std_vector_double_arg) {
std::vector<std::vector<double>> arg(5, std::vector<double>(5, 10.0));

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -117,7 +118,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_std_vector_double_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, std_vector_eigen_vector_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_eigen_vector_arg) {
std::vector<Eigen::VectorXd> arg(2, Eigen::VectorXd::Ones(5));

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -130,7 +131,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_eigen_vector_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, std_vector_eigen_row_vector_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_eigen_row_vector_arg) {
std::vector<Eigen::RowVectorXd> arg(2, Eigen::VectorXd::Ones(5));

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -143,7 +144,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_eigen_row_vector_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, std_vector_eigen_matrix_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_eigen_matrix_arg) {
std::vector<Eigen::MatrixXd> arg(2, Eigen::MatrixXd::Ones(5, 3));

Eigen::VectorXd storage = Eigen::VectorXd::Zero(1000);
Expand All @@ -156,7 +157,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_eigen_matrix_arg) {
EXPECT_EQ(ptr, storage.data());
}

TEST(AgradRev_accumulate_adjoints, var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_var_arg) {
using stan::math::var;
using stan::math::vari;
var arg(5.0);
Expand All @@ -178,7 +179,7 @@ TEST(AgradRev_accumulate_adjoints, var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, std_vector_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_var_arg) {
using stan::math::var;
using stan::math::vari;
std::vector<var> arg(5);
Expand All @@ -203,7 +204,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, eigen_vector_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_eigen_vector_var_arg) {
using stan::math::var;
using stan::math::vari;
Eigen::Matrix<var, Eigen::Dynamic, 1> arg(5);
Expand All @@ -228,7 +229,7 @@ TEST(AgradRev_accumulate_adjoints, eigen_vector_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, eigen_row_vector_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_eigen_row_vector_var_arg) {
using stan::math::var;
using stan::math::vari;
Eigen::Matrix<var, 1, Eigen::Dynamic> arg(5);
Expand All @@ -253,7 +254,7 @@ TEST(AgradRev_accumulate_adjoints, eigen_row_vector_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, eigen_matrix_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_eigen_matrix_var_arg) {
using stan::math::var;
using stan::math::vari;
Eigen::Matrix<var, Eigen::Dynamic, Eigen::Dynamic> arg(5, 5);
Expand All @@ -278,7 +279,7 @@ TEST(AgradRev_accumulate_adjoints, eigen_matrix_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, std_vector_std_vector_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_std_vector_var_arg) {
using stan::math::var;
using stan::math::vari;
std::vector<var> arg_(5, var(5.0));
Expand All @@ -302,7 +303,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_std_vector_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, std_vector_eigen_vector_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_eigen_vector_var_arg) {
using stan::math::var;
using stan::math::vari;
Eigen::Matrix<var, Eigen::Dynamic, 1> arg_(5);
Expand All @@ -328,7 +329,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_eigen_vector_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, std_vector_eigen_row_vector_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_eigen_row_vector_var_arg) {
using stan::math::var;
using stan::math::vari;
Eigen::Matrix<var, 1, Eigen::Dynamic> arg_(5);
Expand All @@ -354,7 +355,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_eigen_row_vector_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, std_vector_eigen_matrix_var_arg) {
TEST_F(AgradRev, Rev_accumulate_adjoints_std_vector_eigen_matrix_var_arg) {
using stan::math::var;
using stan::math::vari;
Eigen::Matrix<var, Eigen::Dynamic, Eigen::Dynamic> arg_(5, 3);
Expand All @@ -380,7 +381,7 @@ TEST(AgradRev_accumulate_adjoints, std_vector_eigen_matrix_var_arg) {
stan::math::recover_memory();
}

TEST(AgradRev_accumulate_adjoints, sum) {
TEST_F(AgradRev, Rev_accumulate_adjoints_sum) {
using stan::math::var;
using stan::math::vari;
int arg1 = 1;
Expand Down
3 changes: 2 additions & 1 deletion test/unit/math/rev/core/arena_allocator_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <stan/math/rev/core.hpp>
#include <test/unit/math/rev/util.hpp>
#include <gtest/gtest.h>
#include <vector>
#include <deque>
Expand Down Expand Up @@ -138,6 +139,6 @@ void arena_allocator_test() {
}
}

TEST(AgradRevArena, arena_allocator_test) {
TEST_F(AgradRev, RevArena_arena_allocator_test) {
EXPECT_NO_THROW(arena_allocator_test());
}
2 changes: 1 addition & 1 deletion test/unit/math/rev/core/arena_matrix_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ TEST_F(AgradRev, arena_sparse_matrix_inplace_ops) {
expect_sparse_dense_matrix_equal(A_m, C);
}

TEST(AgradRevArenaMat, arena_matrix_move_test) {
TEST_F(AgradRev, RevArenaMat_arena_matrix_move_test) {
using stan::math::arena_matrix;
Eigen::VectorXd c = Eigen::VectorXd::Random(3);
Eigen::VectorXd d = c;
Expand Down
3 changes: 2 additions & 1 deletion test/unit/math/rev/core/build_vari_array_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#include <stan/math/rev/core.hpp>
#include <test/unit/math/rev/util.hpp>
#include <gtest/gtest.h>
#include <sstream>

TEST(AgradRevBuild, build_vari_array) {
TEST_F(AgradRev, RevBuild_build_vari_array) {
using Eigen::Dynamic;
using Eigen::Matrix;
using stan::math::var;
Expand Down
11 changes: 6 additions & 5 deletions test/unit/math/rev/core/callback_vari_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#include <stan/math.hpp>
#include <gtest/gtest.h>
#include <test/unit/util.hpp>
#include <test/unit/math/rev/util.hpp>

TEST(AgradRevCBack, callback_vari_scalar_test) {
TEST_F(AgradRev, RevCBack_callback_vari_scalar_test) {
stan::math::var a = 1;
stan::math::var b = 1;

Expand All @@ -20,7 +21,7 @@ TEST(AgradRevCBack, callback_vari_scalar_test) {
EXPECT_EQ(b.adj(), 2);
}

TEST(AgradRevCBack, callback_vari_const_scalar_compile_test) {
TEST_F(AgradRev, RevCBack_callback_vari_const_scalar_compile_test) {
stan::math::var a = 1;

const double& a_val = a.val();
Expand All @@ -30,7 +31,7 @@ TEST(AgradRevCBack, callback_vari_const_scalar_compile_test) {
EXPECT_FLOAT_EQ(a.val(), b.val());
}

TEST(AgradRevCBack, callback_vari_eigen_test) {
TEST_F(AgradRev, RevCBack_callback_vari_eigen_test) {
Eigen::MatrixXd val(2, 3);
val << 1, 2, 3, 4, 5, 6;
stan::math::var_value<Eigen::MatrixXd> a = val;
Expand All @@ -44,7 +45,7 @@ TEST(AgradRevCBack, callback_vari_eigen_test) {
EXPECT_MATRIX_EQ(a.adj(), Eigen::MatrixXd::Constant(2, 3, 2));
}

TEST(AgradRevCBack, make_callback_var_scalar_test) {
TEST_F(AgradRev, RevCBack_make_callback_var_scalar_test) {
stan::math::var a = 1;
stan::math::var b = 1;

Expand All @@ -63,7 +64,7 @@ TEST(AgradRevCBack, make_callback_var_scalar_test) {
EXPECT_EQ(b.adj(), 2);
}

TEST(AgradRevCBack, make_callback_var_eigen_test) {
TEST_F(AgradRev, RevCBack_make_callback_var_eigen_test) {
Eigen::MatrixXd val(2, 3);
val << 1, 2, 3, 4, 5, 6;
stan::math::var_value<Eigen::MatrixXd> a = val;
Expand Down
17 changes: 9 additions & 8 deletions test/unit/math/rev/core/chainable_object_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include <stan/math.hpp>
#include <gtest/gtest.h>
#include <test/unit/util.hpp>
#include <test/unit/math/rev/util.hpp>

class ChainableObjectTest {
public:
Expand All @@ -11,7 +12,7 @@ class ChainableObjectTest {

int ChainableObjectTest::counter = 0;

TEST(AgradRevChain, chainable_object_test) {
TEST_F(AgradRev, RevChain_chainable_object_test) {
{
EXPECT_NO_THROW(new stan::math::chainable_object<ChainableObjectTest>(
ChainableObjectTest()));
Expand All @@ -23,7 +24,7 @@ TEST(AgradRevChain, chainable_object_test) {
EXPECT_EQ((ChainableObjectTest::counter), 1);
}

TEST(AgradRevChain, chainable_object_nested_test) {
TEST_F(AgradRev, RevChain_chainable_object_nested_test) {
stan::math::start_nested();

{
Expand All @@ -39,7 +40,7 @@ TEST(AgradRevChain, chainable_object_nested_test) {
EXPECT_EQ((ChainableObjectTest::counter), 1);
}

TEST(AgradRevChain, make_chainable_ptr_test) {
TEST_F(AgradRev, RevChain_make_chainable_ptr_test) {
{
EXPECT_NO_THROW(stan::math::make_chainable_ptr(ChainableObjectTest()));
ChainableObjectTest::counter = 0;
Expand All @@ -50,7 +51,7 @@ TEST(AgradRevChain, make_chainable_ptr_test) {
EXPECT_EQ((ChainableObjectTest::counter), 1);
}

TEST(AgradRevChain, make_chainable_ptr_nested_test) {
TEST_F(AgradRev, RevChain_make_chainable_ptr_nested_test) {
stan::math::start_nested();

{
Expand All @@ -74,7 +75,7 @@ class UnsafeChainableObjectTest {

int UnsafeChainableObjectTest::counter = 0;

TEST(AgradRevChain, unsafe_chainable_object_test) {
TEST_F(AgradRev, RevChain_unsafe_chainable_object_test) {
{
EXPECT_NO_THROW(
new stan::math::unsafe_chainable_object<UnsafeChainableObjectTest>(
Expand All @@ -87,7 +88,7 @@ TEST(AgradRevChain, unsafe_chainable_object_test) {
EXPECT_EQ((UnsafeChainableObjectTest::counter), 1);
}

TEST(AgradRevChain, unsafe_chainable_object_nested_test) {
TEST_F(AgradRev, RevChain_unsafe_chainable_object_nested_test) {
stan::math::start_nested();

{
Expand All @@ -103,7 +104,7 @@ TEST(AgradRevChain, unsafe_chainable_object_nested_test) {
EXPECT_EQ((UnsafeChainableObjectTest::counter), 1);
}

TEST(AgradRevChain, make_unsafe_chainable_ptr_test) {
TEST_F(AgradRev, RevChain_make_unsafe_chainable_ptr_test) {
{
EXPECT_NO_THROW(
stan::math::make_unsafe_chainable_ptr(UnsafeChainableObjectTest()));
Expand All @@ -115,7 +116,7 @@ TEST(AgradRevChain, make_unsafe_chainable_ptr_test) {
EXPECT_EQ((UnsafeChainableObjectTest::counter), 1);
}

TEST(AgradRevChain, make_unsafe_chainable_ptr_nested_test) {
TEST_F(AgradRev, RevChain_make_unsafe_chainable_ptr_nested_test) {
stan::math::start_nested();

{
Expand Down
Loading