fix: Let users specify initial values#98
Merged
riddell-stan merged 1 commit intostan-dev:masterfrom Apr 17, 2020
riddell-stan:feature/issue94
Merged
fix: Let users specify initial values#98riddell-stan merged 1 commit intostan-dev:masterfrom riddell-stan:feature/issue94
riddell-stan merged 1 commit intostan-dev:masterfrom
riddell-stan:feature/issue94
Conversation
ahartikainen
approved these changes
Apr 16, 2020
Contributor
ahartikainen
left a comment
ahartikainen
left a comment
There was a problem hiding this comment.
Looks good. I added one question about the tests.
| payload.update(kwargs) | ||
| payload["chain"] = chain | ||
| payload["data"] = self.data | ||
| payload["init"] = init.pop(0) |
| real x; | ||
| } | ||
| parameters { | ||
| real mu; |
Contributor
There was a problem hiding this comment.
do we need to test for partial init (init for mu but not for another par)?
Contributor
Author
There was a problem hiding this comment.
In the interest of time, I'm only translating the old pystan tests right now. We can add tests later if we want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78