This repository was archived by the owner on Jul 6, 2022. It is now read-only.
Merged
Conversation
Member
|
Left some comments here: https://github.com/standardnotes/snjs/pull/224/files#r577674680 |
Contributor
Author
atmoio
reviewed
Feb 17, 2021
| * Use this method if you do not want to display protections-related | ||
| * information to a user who cannot currently exploit the feature. | ||
| */ | ||
| public hasProtectionSources(): boolean { |
Member
There was a problem hiding this comment.
What do you think of a comment like this:
Returns true if the user has a source of protection available, such as a passcode, password, or biometrics.
I find the current comment somewhat awkwardly phrased. "Use..if you do not..who cannot..exploit"..
Contributor
Author
There was a problem hiding this comment.
Sounds good! I was struggling with this one
antsgar
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we'll end up with:
SNApplication.hasProtections(): to determine if a user can use the feature at all (which they can't if they don't have an account, passcode, or biometrics authentication)SNApplication.areProtectionsEnabled(): to determine if protections are enabled/disabled