This repository was archived by the owner on Jul 6, 2022. It is now read-only.
feat: add function to return password creation date for user#417
Merged
vardan-arm merged 3 commits intomasterfrom Sep 8, 2021
Merged
feat: add function to return password creation date for user#417vardan-arm merged 3 commits intomasterfrom
vardan-arm merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
Internal link - https://app.asana.com/0/1200588672119490/1200888182977784 |
karolsojko
approved these changes
Sep 8, 2021
atmoio
reviewed
Sep 8, 2021
| } | ||
|
|
||
| public getPasswordCreatedDate(): number | undefined { | ||
| const rootKey = this.protocolService.getRootKey() |
Member
There was a problem hiding this comment.
Suggested change
| const rootKey = this.protocolService.getRootKey() | |
| const rootKey = this.protocolService.getRootKey(); |
atmoio
reviewed
Sep 8, 2021
|
|
||
| public getPasswordCreatedDate(): number | undefined { | ||
| const rootKey = this.protocolService.getRootKey() | ||
| return rootKey ? Number(rootKey.keyParams.content.created) : undefined; |
Member
There was a problem hiding this comment.
Suggested change
| return rootKey ? Number(rootKey.keyParams.content.created) : undefined; | |
| return rootKey ? rootKey.keyParams.createdDate : undefined; |
Member
There was a problem hiding this comment.
This would change the return type to date. Do you need it to be a Number?
Contributor
Author
There was a problem hiding this comment.
No, I just didn't want stringified timestamp, therefore converted to Number :) Thanks, updated!
atmoio
reviewed
Sep 8, 2021
| } | ||
| } | ||
|
|
||
| public getPasswordCreatedDate(): Date | undefined { |
Member
There was a problem hiding this comment.
Sorry didn't catch this earlier, but I would put this function in protocol_service instead since root key is the domain of the protocol service.
Contributor
Author
There was a problem hiding this comment.
Good point, yeah, getRootKey comes from protocol service, so it makes more sense, done.
atmoio
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.