This repository was archived by the owner on Jul 6, 2022. It is now read-only.
Conversation
antsgar
reviewed
Oct 6, 2021
| } | ||
| break; | ||
| ); | ||
| } else if (!expired || feature.content_type === ContentType.Component) { |
Contributor
There was a problem hiding this comment.
If I'm following correctly with this logic we won't be creating items for inexistent themes, we'd probably need to remove the second condition here?
Member
Author
There was a problem hiding this comment.
We'd only create themes if it is not expired. Otherwise if it is expired, we only proceed with creating an item if Component, because we can mark them as read-only.
This was the previous logic, just rewritten to not use switches and factor out common denominators.
Contributor
There was a problem hiding this comment.
Ah don't know why I read the || as an &&, understood now, thanks!
antsgar
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.