Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

fix: reverse title sort#757

Merged
atmoio merged 3 commits intomasterfrom
fix/title-sort
Jun 6, 2022
Merged

fix: reverse title sort#757
atmoio merged 3 commits intomasterfrom
fix/title-sort

Conversation

@atmoio
Copy link
Copy Markdown
Member

@atmoio atmoio commented Jun 6, 2022

No description provided.

(sortDirection === 'asc' && !CollectionSortHumanPerceptionPrefersInverseDirection[sortBy]) ||
(sortDirection === 'dsc' && CollectionSortHumanPerceptionPrefersInverseDirection[sortBy])

let compareResult = KeepSameOrder

Check warning

Code scanning / CodeQL

Useless assignment to local variable

The initial value of compareResult is unused, since it is always overwritten.
@atmoio atmoio merged commit dacee77 into master Jun 6, 2022
@atmoio atmoio deleted the fix/title-sort branch June 6, 2022 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant