Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
9a8026c
feat(tests): add requirements-dev.txt
May 21, 2024
35dcaed
feat(tests): BaseIntegrationTestWithCache
May 21, 2024
a1c8491
feat(tests): ignore assert in ruff
May 21, 2024
6f1c120
feat(tests): TestIntroIntegration
May 21, 2024
b773796
feat(tests): TestIntroIntegration
May 21, 2024
32b5470
feat(tests): TestIntroIntegration
May 21, 2024
2e10d67
feat(tests): add integration test to CI.
May 21, 2024
6df93fc
feat(tests): add integration test to CI.
May 21, 2024
195cd03
feat(tests): add integration test to CI.
May 21, 2024
965fbf3
feat(tests): add integration test to CI.
May 21, 2024
ff075fe
feat(tests): add integration test to CI.
May 21, 2024
56b00ad
feat(tests): add integration test to CI.
May 21, 2024
742eb56
feat(tests): add pytest.ini for integration
May 25, 2024
598f831
feat(tests): add pytest.ini for integration
May 25, 2024
73ff317
feat(tests): change it to ci way -_-
May 25, 2024
f6a64e3
feat(tests): change it to ci way -_-
May 25, 2024
e593154
feat(tests): change it to ci way -_-
May 25, 2024
35c39ad
feat(tests): change it to ci way -_-
May 25, 2024
065f2d1
feat(tests): change it to ci way -_-
May 25, 2024
81851d1
feat(tests): change it to ci way -_-
May 25, 2024
f7fa698
feat(tests): change it to ci way -_-
May 25, 2024
3b7da8d
feat(tests): change it to ci way -_-
May 25, 2024
11c84bb
feat(tests): change it to ci way -_-
May 25, 2024
d96c0ce
feat(tests): change it to ci way -_-
May 25, 2024
b4f3391
feat(tests): change it to ci way -_-
May 25, 2024
0098e4e
feat(tests): cache file.
May 25, 2024
8f81e6c
feat(tests): cache file.
May 25, 2024
b2e51bb
feat(tests): cache file.
May 25, 2024
cac66f8
feat(tests): cache file.
May 25, 2024
a7c229e
feat(tests): cache file.
May 25, 2024
4ad4b9f
feat(tests): cache file.
May 25, 2024
29ec21f
feat(tests): add print for start file.
May 25, 2024
9de0989
feat(tests): fix versions for cache.
May 25, 2024
abdb933
feat(tests): fix versions for cache.
May 25, 2024
c5e1e28
feat(tests): fix cache in the ci.
May 25, 2024
87dd340
feat(tests): fix cache in the ci.
May 25, 2024
f14c91d
feat(tests): fix cache in the ci.
May 25, 2024
9811198
feat(tests): remove top import.
May 25, 2024
9c2652d
feat(tests): add new pytest-ci.ini
May 25, 2024
f5573c5
feat(tests): fix run_tests.yml
May 25, 2024
d6a36f9
feat(tests): fix run_tests.yml
May 25, 2024
5d994d4
feat(tests): fix run_tests.yml
May 25, 2024
a6f1395
feat(tests): remove pytest-ci.ini
May 25, 2024
5f31aa2
feat(tests): split requirements and requirements-dev
May 25, 2024
53fb2a5
feat(tests): revert cache
May 25, 2024
9a847f5
feat(tests): revert cache
May 25, 2024
a11e80e
feat(tests): revert pre-commit.
May 25, 2024
c1aa768
feat(tests): clean up.
May 25, 2024
f0bd17d
feat(tests): show ruff errors.
May 25, 2024
c1d49c0
feat(tests): revert requirements.
May 25, 2024
66309ee
feat(tests): fix ruff.
May 25, 2024
1be9a20
feat(tests): fix ruff.
May 25, 2024
01b671d
feat(tests): fix ruff.
May 25, 2024
26f2ffd
feat(tests): fix ruff.
May 25, 2024
b42e8bf
feat(tests): fix ruff.
May 25, 2024
c9e687e
feat(tests): cleanup.
May 25, 2024
1c65f3c
feat(tests): remove second ruff.
May 25, 2024
e06883c
feat(tests): arnav comments on intro integration
May 26, 2024
beca119
feat(tests): revert requirements.txt
May 27, 2024
481e0f1
feat(tests): remove base.py
May 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
with:
args: --fix-only --exit-non-zero-on-fix
continue-on-error: true

- name: Fail Workflow if Ruff Fix Failed
if: steps.ruff_fix.outcome == 'failure'
run: |
Expand Down Expand Up @@ -120,3 +119,28 @@ jobs:
cache: "poetry"
- name: Run setup.py build
run: python setup.py build

integration_test:
name: Run Integration Tests
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fully sure but is it needed to specify a python version here? (can we extend this to >=3.9 as in dspy-ai?) and how does this affect users who don't have 3.9 - (saw a followup to this issue here more so for dspy-ai but similar impact).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested on other pythons, I would say definitely we can add other python versions testing but I suggest defer it after merging my other PR about moving all dependencies to the poetry.

pip requirements doesn't have good caching system in the CI and if we want to add other python version testing in our CI it would consume our CI resources very fast.

steps:
- uses: actions/checkout@v4
- name: Set up python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: "pip"
- run: pip install -r requirements.txt
- run: pip install -r requirements-dev.txt
- run: pip install openai==0.28.1
- name: Add directory to Python path
run: echo "PYTHONPATH=$(python -c 'import sys; print(":".join(sys.path))'):$(pwd)" >> $GITHUB_ENV
- name: Set up cache directory
run: |
cd ./cache
echo "DSP_NOTEBOOK_CACHEDIR=$(pwd)" >> $GITHUB_ENV
- name: Run tests with pytest
run: pytest -c tests_integration/pytest.ini tests_integration/
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,8 @@ ignore = [
"E731",
# Sometimes we need List and Tuple
"UP006",
# Ignore assert
"S101",
]

# Allow fix for all enabled rules (when `--fix`) is provided.
Expand Down
8 changes: 8 additions & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
black==24.2.0
pre-commit==3.7.0
pytest==8.2.1
pytest-env==1.1.3
pytest-mock==3.12.0
ruff==0.3.0
torch==2.2.1
transformers==4.38.2
3 changes: 3 additions & 0 deletions tests/pytest.ini β†’ tests_integration/pytest.ini
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[pytest]
filterwarnings =
ignore::DeprecationWarning

env =
DSP_NOTEBOOK_CACHEDIR=./cache
Loading