linter: black & isort for auto-formatting on PRs #125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawliet19189
changed the title
Collaborator
|
What's needed for this to be merged? What are the downsides of merging it? Will it complicate the workflow? |
Contributor
|
I would not split this into separate parts but rather package it all into a dedicated pre-commit + related worflow (which will help much better locally before doing PRs) -> I can set this up. |
Collaborator
|
@piotrlaczkowski I invited you to the repo! Please feel free to merge this when you feel it's at a good stage! |
Contributor
|
@okhat I still have 403 upon the push for my new branch, just tested. |
Contributor
|
I think we can close this one (both tools are already present in the pre commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.