modified signatures to handle new DSPy signature format #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhat
reviewed
Oct 8, 2023
dspy/signatures/signature.py
Outdated
| field_instance = field_type | ||
| else: | ||
| raise ValueError(f"non-existent {field_type}.") | ||
| if position == "prepend": |
Collaborator
There was a problem hiding this comment.
I don't think this will handle append/prepend correctly considering that inputs must all go before outputs
Collaborator
There was a problem hiding this comment.
Probably need to find the endpoint of the input fields (for append to inputs or prepend to outputs)
Collaborator
|
Do we close this one now, @arnavsinghvi11 |
Collaborator
|
posted important old notes above, they probably didn't show for you before also do we close this PR since this stuff is now part of PoT's PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-supports new DSPy signature declarations (
dspy.Signature("{inputs}-> {outputs}")methods added:
-
attach(): defining field with prefix and description-
add_field(): supports pretending and appending InputFields and OutputFields(note for reference - currently, modifies signature in-place as the
attach()functionality supports chaining)