Skip to content

Conversation

@okhat
Copy link
Collaborator

@okhat okhat commented Dec 16, 2024

No description provided.

@okhat okhat changed the title Simplify built-in modules (remove extended_signature and new_signature) and remove assertions temporarily Simplify built-in modules (remove new_* & extended_signature). Remove assertions temporarily. Dec 16, 2024
@okhat okhat changed the title Simplify built-in modules (remove new_* & extended_signature). Remove assertions temporarily. Simplify built-in modules (remove new_* & extended_signature). Prepare for assertions v2. Dec 16, 2024
@okhat okhat merged commit ae86009 into main Dec 16, 2024
4 checks passed
@asparagus
Copy link
Contributor

Where can I read about assertions v2?

@marfago
Copy link

marfago commented Feb 2, 2025

@okhat I have just updated from v2.5 to 2.6 and my code does not work anymore becuase dspy.Assert and dspy.Suggest do not exist anymore. Can you please share some documentation to port them from v2.5 to v2.6?

@Nasreddine
Copy link

@okhat I have just updated from v2.5 to 2.6 and my code does not work anymore becuase dspy.Assert and dspy.Suggest do not exist anymore. Can you please share some documentation to port them from v2.5 to v2.6?

I think you should revert to v2.5, as I did, since assertions in v2 are not yet complete.

I wonder why assertions were removed while v2 is still not fully implemented.

@marfago
Copy link

marfago commented Feb 3, 2025

@Nasreddine Thank you for confirming. I have already reverted to the previous version. I agree with you, this is a regression of 2.6.0 with respect to 2.5.x (the entire assertion logic code has been commented out and the feature removed).

I would also add that the documentation is quite messy right now between 2.4/2.5/2.6 and it is not really clear what the recommended approach (and not just for assertions) is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants