Skip to content

Conversation

@quajak
Copy link
Contributor

@quajak quajak commented Mar 5, 2024

Addresses #477

@arnavsinghvi11
Copy link
Collaborator

Thanks @quajak !

@isaacbmiller similar tag here as the PR is failing checks

@quajak
Copy link
Contributor Author

quajak commented Mar 5, 2024

Hi, not sure why the checks are failing with the current error.

@isaacbmiller
Copy link
Collaborator

This is blocked until #565 is merged. I will have time to finish 565 tomorrow/thursday.

This is only not passing because it comes from a fork instead of the main repo. @quajak if you are okay with not being the author/need this asap (I want you to get the contribution!) I can make a branch.

@quajak
Copy link
Contributor Author

quajak commented Mar 6, 2024

I see. Thank you for the explanation. The PR is not urgent, so you can wait with merging until #565 is done.

@okhat okhat merged commit 4ed88d9 into stanfordnlp:main Mar 7, 2024
@quajak quajak deleted the fix/evaluate branch March 8, 2024 17:00
@quajak
Copy link
Contributor Author

quajak commented Mar 9, 2024

The changes seem to have been reverted by e659fc2 as part of #565 . Was this intentional?

@isaacbmiller
Copy link
Collaborator

I merged and reverted to check if CI would pass, but I still wanted you to merge yours after

@quajak quajak restored the fix/evaluate branch March 10, 2024 00:50
@quajak
Copy link
Contributor Author

quajak commented Mar 10, 2024

I see, should I make a new PR with the changes?

@isaacbmiller
Copy link
Collaborator

Weird. I guess so @quajak. Tag me and I will merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants