-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Adds native support for Claude models #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you. It would be great if this files is updated, |
|
Thanks a lot! No don't update setup.py, this does not need to be a global requirement. Instead the import should happen only if needed, e.g. inside |
|
@insop could you please help me with the ruff check here? I tried with: |
I am new to But I gave it a try by merging this PR branch to current main a51aad7. Here is what I found:
It is appeared to be that there is some config file change or some type of cached information are playing here? Sorry, I tried, not no answer to this. |
|
Ok, so good to merge this PR without passing the ruff test? Lgtm otherwise, maybe before every release we run the ruff test on master until this is fully understood within the team going forward? |
|
Looking into this now. Do not merge yet, the test failing is not CI fault |
|
@CShorten How are you pushing to this pull request? |
|
Okay I fixed the issues:
|
|
Thank you so much @insop @isaacbmiller @skucherlapati @okhat! Really appreciate your contributions to this! Claude API in DSPy!! Super cool! |
|
Thanks for the help on getting this merged. Makes sense - I should have made it optional! |
Adds native support for claude wrapper