WIP fix: cache for the baleen test and add notebook cache to everywhere. #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasahle
reviewed
Mar 8, 2024
| # @pytest.mark.slow_test | ||
| # TODO: Find a way to make this test run without the slow hotpotqa dataset | ||
| def _test_compiled_baleen(): | ||
| def test_compiled_baleen(): |
Collaborator
There was a problem hiding this comment.
Isn't it going to break things to have a unittest using OpenAI like this?
Collaborator
Author
There was a problem hiding this comment.
With the other change that I added in another file this should run based on the cache of the notebook.
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is change?
Why the change is important?
Why not putting it in actual test or decorator?
How to test?