enh: bump lancedb to 0.19.0 and unblock Python 3.13
#7912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks so much @stevapple ! cc @chenmoneygithub We should probably get rid of a lot of the "optional" dependencies that aren't doing anything in practice... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved the incompatibility of
lancedb(originally fixing tonumpyv1) andfastembed(newer versions requiringnumpyv2) and thus unblocked Python 3.13 support.We have long been using Python 3.13 with DSPy (before the 2.6.6 release which no longer allows that) so it should be already supported.
lancedbis an optional dependency and will not affect users of DSPy only.