Fix responses API #8880
Merged
Fix responses API #8880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomeHirata
approved these changes
Oct 1, 2025
TomeHirata
reviewed
Oct 1, 2025
| tool_calls = [] | ||
| reasoning_contents = [] | ||
|
|
||
| for output_item in response.output: |
There was a problem hiding this comment.
nit: Maybe add a comment that even though the output field of the responses API is a list, all output items belong to a single choice
TomeHirata
reviewed
Oct 1, 2025
| elif output_item_type == "function_call": | ||
| tool_calls.append(output_item.model_dump()) | ||
| elif output_item_type == "reasoning": | ||
| if getattr(output_item, "content", None) and len(output_item.content) > 0: |
There was a problem hiding this comment.
q: is it possible that output_item does not have content attribute when the item type is reasoning?
There was a problem hiding this comment.
technically it's possible that either content or summary is unset, but again OpenAI is doing an odd job documenting Responses API.
TomeHirata
reviewed
Oct 1, 2025
| if getattr(output_item, "content", None) and len(output_item.content) > 0: | ||
| for content_item in output_item.content: | ||
| reasoning_contents.append(content_item.text) | ||
| elif getattr(output_item, "summary", None) and len(output_item.summary) > 0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responses API always return one choice instead of multiple choice. This is a very confusing behavior without clear documentation, but basically all items in the
outputin Response object map to one choice.