Loosen requirement on datasets package
#971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @krishnan-chandra ! |
shermansiu
added a commit
to shermansiu/dspy
that referenced
this pull request
Mar 10, 2025
In May 2024, the following request was made to loosen the versioning requirements: stanfordnlp#971 `datasets` 3 was released later that year in September 2024. Can we increase the upper bound accordingly?
okhat
pushed a commit
that referenced
this pull request
Mar 12, 2025
* Remove upper bound on datasets version In May 2024, the following request was made to loosen the versioning requirements: #971 `datasets` 3 was released later that year in September 2024. Can we increase the upper bound accordingly? * Update poetry.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the requirement on the
datasetspackage is"datasets~=2.14.6,<3.0.0". Based on Poetry's specifications for tilde requirements, this means that only 2.14 patch releases can be used for the datasets package (and the<3.0.0part of the requirement isn't doing anything).But this is needlessly restrictive, as the datasets package is now up to version 2.19.0. Additionally, restricting datasets to such a low version causes issues with resolution alongside other packages that require
datasetsas well.The primary usage of datasets is to call
load_dataset, which shouldn't be affected by this version constraint.Solution: Change the
~=2.14.6to>=2.14.6instead, which makes version solving significantly easier.