Skip to content

Conversation

@nic-planet
Copy link
Contributor

What I'm changing

  • Adding FAILED and EXPIRED OrderStatusCodes
    We may get away with grouping those two failure modes into a single code, but I think we should have one.

Checklist

  • [X ] Tests pass: uv run pytest

  • Checks pass: uv run pre-commit --all-files
    FYI: pre-commit: error: unrecognized arguments: --all-files

  • CHANGELOG is updated (if necessary)

@nic-planet nic-planet requested a review from gadomski as a code owner April 2, 2025 12:05
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since stapi-pydantic should function as a reference implementation for the spec itself, I think we should either:

I do see this text in that page:

Providers may support additional statuses through extensions. For example:

So we do need to update OrderStatusCode to allow custom statuses.

@gadomski gadomski mentioned this pull request Apr 2, 2025
@nic-planet
Copy link
Contributor Author

Since stapi-pydantic should function as a reference implementation for the spec itself, I think we should either:

I do see this text in that page:

Providers may support additional statuses through extensions. For example:

So we do need to update OrderStatusCode to allow custom statuses.

Oh you're right, I'm requesting that change here when actually I wanted to request it changed in the spec. Thanks for the custom statuses issue; I've also opened stapi-spec/stapi-spec#261 requesting that we have at least one status to represent a failed state.

@gadomski
Copy link
Member

gadomski commented Apr 2, 2025

Sounds good! Marking as draft until it lands in the spec so we can align with whatever is decided there.

@gadomski gadomski marked this pull request as draft April 2, 2025 20:54
@gadomski gadomski mentioned this pull request Apr 3, 2025
2 tasks
@gadomski gadomski self-assigned this Apr 3, 2025
@gadomski gadomski requested a review from a team April 3, 2025 13:57
@gadomski gadomski marked this pull request as ready for review April 3, 2025 13:57
@gadomski gadomski changed the title Add OrderStatusCode values to reflect failure modes for orders feat: add OrderStatusCode values to reflect failure modes for orders Apr 3, 2025
@gadomski gadomski merged commit 7ea239f into main Apr 3, 2025
4 checks passed
@gadomski gadomski deleted the more-order-status-codes branch April 3, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants