-
Notifications
You must be signed in to change notification settings - Fork 5
Wide-ranging docs update #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being a huge change in the infrastructure and content of the guides.
It's not really possible to enumerate everything, because not much of the original infrastructure remains.
Some infrastructure notes:
src/.vitepressinto standalone packages:::containers: you need to add extra space inside of the:::to avoid the contents of the container getting slurped into the:::header```md, which correctly syntax highlights and gets the correct prettier behavior.!(./relative/file.ts#region)). I tried to use, which had the nice property of supporting "jump to definition", but repurposing image syntax also triggered lint and build-time warnings.d2binary. Wrote a script to automatically fetch thed2binary inprepareso it's transparently present.Content notes:
There are many, many more changes, but these are some important ones that come to mind.
Final note: The infrastructure around the standalone packages isn't amazing, especially around dev-mode experience. This is because I focused primarily on extracting code into packages that could be ultimately extracted out of the repo, and Vite doesn't make it easy for in-repo packages to have a seamless development experience.
I plan to completely extract the bulk of these packages to their own repo pretty soon, so I decided not to try to fight Vite's perspective on this and live with the fact that the process for modifying the standalone packages isn't totally seamless. TL;DR instead of writing a bunch of contributor guides for contributing to these packages, I plan to move them into their own repositories with their own workflow.