fix: remove test not rpc0.8 #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penovicp
reviewed
Nov 19, 2025
Collaborator
penovicp
left a comment
penovicp
left a comment
There was a problem hiding this comment.
A test in account.test.ts that checks for the removed assert should also be removed.
penovicp
approved these changes
Nov 19, 2025
tabaktoni
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
In Account.fastExecute(), there is an
assertto be sure to not use the function with rpc0.8.As rpc v0.8 is no more in starknet.js v9, this test has to be removed.
Usage related changes
Development related changes
Checklist: