Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Devs are complaining to have a flood of error messages when using snjs Devnet, integration or Testnet networks.
Estimation of tip is optimized for Mainnet, but is generating a lot of error messages when using other networks, due to a low quantity of transactions per block.
To be less disruptive for devs, I propose to replace the error message by a warning message.
Usage related changes
In node.js, jest tests, browser console, very aggressive error messages are now replaced by warnings.
Development related changes
Note
starknet.js/src/provider/modules/tip.ts
Lines 386 to 392 in 27f2a9b
I ask me if it's a good idea to return a zero value if not enough txs have been found.
It could be better to respond zero only if nothing has been found, and in other cases, try to calculate the tip.
Checklist: