Skip to content

refactor(apollo_signature_manager): move code from lib.rs #7310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

refactor(apollo_signature_manager): move code from lib.rs #7310

merged 1 commit into from
Jun 16, 2025

Conversation

@elintul
Copy link
Contributor

@elintul elintul commented Jun 16, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jun 16, 2025

This change is Reviewable

@elintul elintul requested a review from giladchase June 16, 2025 09:55
@elintul elintul marked this pull request as ready for review June 16, 2025 09:55
@elintul Graphite App
Copy link
Contributor Author

elintul commented Jun 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

Artifacts upload workflows:

@elintul elintul force-pushed the 06-16-refactor_apollo_signature_manager_move_code_from_lib.rs_ branch from e87e443 to a0bf8c7 Compare June 16, 2025 09:56
giladchase
giladchase approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

@elintul elintul force-pushed the 06-16-refactor_apollo_signature_manager_move_code_from_lib.rs_ branch from a0bf8c7 to 8b69b93 Compare June 16, 2025 09:57
@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [34.464 ms 34.611 ms 34.828 ms] change: [-6.6037% -4.5225% -2.5985%] (p = 0.00 < 0.05) Performance has improved. Found 10 outliers among 100 measurements (10.00%) 7 (7.00%) high mild 3 (3.00%) high severe

@elintul elintul mentioned this pull request Jun 16, 2025
Merged
elintul
elintul commented Jun 16, 2025
View reviewed changes
Copy link
Contributor Author

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

This was referenced Jun 16, 2025
Merged
Merged
@elintul elintul added this pull request to the merge queue Jun 16, 2025
Merged via the queue into main with commit 55da458 Jun 16, 2025
11 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@giladchase giladchase giladchase approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elintul @reviewable-StarkWare @giladchase