l1: use AnvilBaseLayer in multi-contract events test

[giladchase]

No description provided.

[reviewable-StarkWare]

This change is 

[giladchase]

• l1: add mocked starknet contract #8459
• apollo_integration_tests: ban anvil in unit tests #8458
• l1: move anvil and associated tests into integration test crate #8444
• l1: move anvil test util into single use-case #7791
• l1: remove unused test-utils in favor of AnvilBaseLayer #7790
• l1: convert events_from_other_contracts test into integration test #7789
• l1: move send_messages_to_l2 util into AnvilBaseLayer #8264
• l1: rename args in test, to be symmetric with other_contract #8263
• l1: change nonce into n_txs in starknet_api_test_utils #8262
• l1: remove eth l1 nonce from send_messages_to_l2 #8261
• l1: use AnvilBaseLayer in multi-contract events test #7788 👈 (View in Graphite)
• l1: remove out of scope assertion in test #7787
• l1: use AnvilBaseLayer in integration test #7786
• apollo_integration_tests: use AnvilBaseLayer #7785
• l1: add consts to anvil pre-funded accounts #7784
• l1: consolidate Ethereum contract address re-export #7783
• l1: add anvil base layer #7782
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @matan-starkware)

---

crates/papyrus_base_layer/src/base_layer_test.rs line 133 at r1 (raw file):

    // Deploy another instance of the contract to the same anvil instance.
    let other_contract = Starknet::deploy(this_contract.contract.provider().clone()).await.unwrap();

I suggest dedicating a line to the provider, otherwise it looks odd that we use "this_contract" to declare the other contract.
I wrote the original line. #sorry.

Wait - can we get the provider for anvil_base_layer - without passing through this_contract?

Suggestion:

    // Deploy another instance of the contract to the same anvil instance.
    let provider = this_contract.contract.provider().clone();
    let other_contract = Starknet::deploy(provider).await.unwrap();

[giladchase]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ArniStarkware and @matan-starkware)

---

crates/papyrus_base_layer/src/base_layer_test.rs line 133 at r1 (raw file):
Done.

Wait - can we get the provider for anvil_base_layer - without passing through this_contract?

We'll need to call this, which needs a config and node URL, but the coupling between those and the contract are the reason why base layer abstraction exists, so trying to create a new contract by hand will duplicate it's constructor logic basically, I think.

[ArniStarkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[graphite-app]

Merge activity

• Aug 5, 10:37 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.