blockifier: test L3 compatability in syscalls

[einat-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[einat-starkware]

• blockifier: test L3 compatability in syscalls #7816 👈 (View in Graphite)
• blockifier: add l3 compatibility for addresses #7763
• blockifier: add l3 field to ChainInfo #7729
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-07-07T10:26:24Z
• Started at 2025-07-08T14:04:03Z
• Started at 2025-07-09T06:12:20Z
• Started at 2025-07-09T07:07:36Z
• Started at 2025-07-09T07:28:50Z
• Started at 2025-07-09T08:19:46Z
• Started at 2025-07-09T08:19:58Z
• Started at 2025-07-09T08:19:53Z
• Started at 2025-07-09T08:21:45Z

[Yoni-Starkware]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 136 at r1 (raw file):

        BlockContext { chain_info: chain_info.clone(), ..BlockContext::create_for_testing() };

    let invalid_to_address = felt!("0x1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF");

Please choose a tight value (+1 the limit).

Code quote:

felt!("0x1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF");

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 156 at r1 (raw file):

    let result = entry_point_call.execute_directly_given_block_context(&mut state, block_context);
    assert!(result.is_ok(), "Expected execution to succeed on L3 chain");
}

Please join these two into a single test, to save code duplication.
Add a variable is_l3 and check th expected result according to it

Code quote:

#[cfg_attr(feature = "cairo_native", test_case(RunnableCairo1::Native; "Native"))]
#[test_case(RunnableCairo1::Casm; "VM")]
fn test_send_message_to_l1_invalid_address(runnable_version: RunnableCairo1) {
    let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1(runnable_version));
    let chain_info = &ChainInfo::create_for_testing();
    let mut state = test_state(chain_info, BALANCE, &[(test_contract, 1)]);

    let invalid_to_address = felt!("0x1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF");
    let payload = vec![felt!(2019_u16), felt!(2020_u16)];
    let calldata = Calldata(
        concat(vec![
            vec![
                invalid_to_address,
                felt!(u64::try_from(payload.len()).expect("Failed to convert usize to u64.")),
            ],
            payload.clone(),
        ])
        .into(),
    );
    let entry_point_call = CallEntryPoint {
        entry_point_selector: selector_from_name("test_send_message_to_l1"),
        calldata,
        ..trivial_external_entry_point_new(test_contract)
    };

    let result = entry_point_call.execute_directly(&mut state);
    assert!(result.is_err(), "Expected execution to fail with invalid address");

    // Verify the error is related to address format
    let error = result.unwrap_err();
    let error_string = error.to_string();
    assert!(
        error_string.contains("Out of range"),
        "Expected error containing 'Out of range', got: {}",
        error_string
    );
}

#[cfg_attr(feature = "cairo_native", test_case(RunnableCairo1::Native; "Native"))]
#[test_case(RunnableCairo1::Casm; "VM")]
fn test_send_message_to_l1_l3_address(runnable_version: RunnableCairo1) {
    let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1(runnable_version));
    let mut chain_info = ChainInfo::create_for_testing();
    chain_info.is_l3 = true;
    let mut state = test_state(&chain_info, BALANCE, &[(test_contract, 1)]);

    let block_context =
        BlockContext { chain_info: chain_info.clone(), ..BlockContext::create_for_testing() };

    let invalid_to_address = felt!("0x1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF");
    let payload = vec![felt!(2019_u16), felt!(2020_u16)];
    let calldata = Calldata(
        concat(vec![
            vec![
                invalid_to_address,
                felt!(u64::try_from(payload.len()).expect("Failed to convert usize to u64.")),
            ],
            payload.clone(),
        ])
        .into(),
    );
    let entry_point_call = CallEntryPoint {
        entry_point_selector: selector_from_name("test_send_message_to_l1"),
        calldata,
        ..trivial_external_entry_point_new(test_contract)
    };

    let result = entry_point_call.execute_directly_given_block_context(&mut state, block_context);
    assert!(result.is_ok(), "Expected execution to succeed on L3 chain");
}

[Yoni-Starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @einat-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 156 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please join these two into a single test, to save code duplication.
Add a variable is_l3 and check th expected result according to it

Same re the deprecated test

[einat-starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 136 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please choose a tight value (+1 the limit).

Done.

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 156 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Same re the deprecated test

Done.

[Yoni-Starkware]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

#[cfg_attr(feature = "cairo_native", test_case(RunnableCairo1::Native, true; "Native-L3"))]
#[test_case(RunnableCairo1::Casm, true; "VM-L3")]
fn test_send_message_to_l1_invalid_address(runnable_version: RunnableCairo1, is_l3: bool) {

Nice syntax for simple cases
Same in deprecated test

Suggestion:

#[cfg_attr(feature = "cairo_native", test_case(RunnableCairo1::Native; "Native"))]
#[test_case(RunnableCairo1::Casm; "VM")]
fn test_send_message_to_l1_invalid_address(runnable_version: RunnableCairo1, #[values(true, false)] is_l3: bool) {

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 121 at r2 (raw file):

    } else {
        entry_point_call.execute_directly(&mut state)
    };

Simpler, and does not rely on the implicit default value of block context
Same in deprecated test

Suggestion:

    let block_context =
            BlockContext { chain_info: chain_info.clone(), ..BlockContext::create_for_testing();
    let result = entry_point_call.execute_directly_given_block_context(&mut state, block_context);

[einat-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Nice syntax for simple cases
Same in deprecated test

Changed in the deprecated syscall but not here - it combines two different packages for testing and I couldn't get it to compile without explicitly defining the 4 test cases like before.

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 121 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Simpler, and does not rely on the implicit default value of block context
Same in deprecated test

Done both here and in the deprecated syscall :)

[Yoni-Starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

Previously, einat-starkware wrote…

Changed in the deprecated syscall but not here - it combines two different packages for testing and I couldn't get it to compile without explicitly defining the 4 test cases like before.

Try:

[rstest]
#[cfg_attr(feature = "cairo_native", case(RunnableCairo1::Native; "Native"))]
#[case(RunnableCairo1::Casm; "VM")]
fn test_send_message_to_l1_invalid_address(#[case] runnable_version: RunnableCairo1,  #[values(true, false)] is_l3: bool) {

[einat-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Try:

[rstest]
#[cfg_attr(feature = "cairo_native", case(RunnableCairo1::Native; "Native"))]
#[case(RunnableCairo1::Casm; "VM")]
fn test_send_message_to_l1_invalid_address(#[case] runnable_version: RunnableCairo1,  #[values(true, false)] is_l3: bool) {

Still didn't work unfortunately :/

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

Previously, einat-starkware wrote…

Still didn't work unfortunately :/

Checking

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Checking

#[rstest]
#[cfg_attr(feature = "cairo_native", case::native(RunnableCairo1::Native))]
#[case::vm(RunnableCairo1::Casm)]
fn test_send_message_to_l1_invalid_address(
    #[case] runnable_version: RunnableCairo1,
    #[values(true, false)] is_l3: bool,
) {

[Yoni-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @einat-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 97 at r3 (raw file):

    let mut state = test_state(&chain_info, BALANCE, &[(test_contract, 1)]);

    let invalid_to_address = felt!("0x100000000000000000000000000000000000000001");

Not tight :)

Code quote:

felt!("0x100000000000000000000000000000000000000001")

[Yoni-Starkware]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[einat-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 91 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

#[rstest]
#[cfg_attr(feature = "cairo_native", case::native(RunnableCairo1::Native))]
#[case::vm(RunnableCairo1::Casm)]
fn test_send_message_to_l1_invalid_address(
    #[case] runnable_version: RunnableCairo1,
    #[values(true, false)] is_l3: bool,
) {

Done.

---

crates/blockifier/src/execution/syscalls/syscall_tests/send_message_to_l1.rs line 97 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Not tight :)

Oh oops, added an extra digit, should be good now.

[Yoni-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)