apollo_batcher: add compiled_class_hashes_for_migration to blob pram #8049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
|
This change is |
Contributor
Author
noaov1
approved these changes
Jul 17, 2025
Collaborator
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
from
437b117 to
2d36ed7
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_central_objects
branch
from
1d616f9 to
20f1ec9
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
from
2d36ed7 to
a81a402
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_central_objects
branch
from
20f1ec9 to
52ff22e
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
from
a81a402 to
f8df09a
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_central_objects
branch
from
52ff22e to
82bce81
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
2 times, most recently
from
fdcfdaf to
aabbd98
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_central_objects
branch
from
82bce81 to
2f6aec9
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_central_objects
branch
from
2f6aec9 to
b02ebf3
Compare
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
from
aabbd98 to
61fb621
Compare
noaov1
approved these changes
Jul 17, 2025
Collaborator
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:
avivg-starkware
changed the base branch from
avivg/add_migration_to_central_objects
to
graphite-base/8049
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
from
61fb621 to
cd51347
Compare
avivg-starkware
force-pushed
the
graphite-base/8049
branch
from
b02ebf3 to
129c38f
Compare
noaov1
approved these changes
Jul 17, 2025
Collaborator
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:
avivg-starkware
force-pushed
the
avivg/add_migration_to_blob_parms
branch
from
cd51347 to
6be90eb
Compare
noaov1
approved these changes
Jul 17, 2025
Collaborator
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.