-
Notifications
You must be signed in to change notification settings - Fork 65
blockifier: pass nested_multiple_int_list directly #8462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockifier: pass nested_multiple_int_list directly #8462
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
05b347d to
b3ae4c1
Compare
470f7f7 to
ed6fc81
Compare
b3ae4c1 to
7899d22
Compare
ed6fc81 to
3714347
Compare
3714347 to
bb2a656
Compare
7899d22 to
7e152d9
Compare
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/native_blockifier/src/py_testing_wrappers.rs line 28 at r2 (raw file):
let node = NestedMultipleIntList::Leaf( bytecode_segment_lengths, FeltSizeGroups { small: 0, large: 0 },
Consider deriving the default trait.
Code quote:
FeltSizeGroups { small: 0, large: 0 },bb2a656 to
ac1be6d
Compare
7e152d9 to
f1a364a
Compare
ac1be6d to
4f7f1e8
Compare
f1a364a to
4dbfcfb
Compare
avivg-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
crates/native_blockifier/src/py_testing_wrappers.rs line 28 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Consider deriving the default trait.
yes thanks, added
4f7f1e8 to
f9ffea8
Compare
4dbfcfb to
e04770e
Compare
f9ffea8 to
0f703aa
Compare
e04770e to
097fa12
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should open a python PR for it.
Consider deleting this test if @Yoni-Starkware agrees, we have a similar test in Rust.
estimate_casm_hash_computation_resources_for_testing_list
estimate_casm_hash_computation_resources_for_testing_single
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
097fa12 to
9f6a62e
Compare
0f703aa to
1616c8c
Compare
avivg-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this doesn't break, see Py PR: https://reviewable.io/reviews/starkware-industries/starkware/38860
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
9f6a62e to
8eb3f10
Compare
1616c8c to
8b98bd1
Compare
8eb3f10 to
ceb85ba
Compare
Merge activity
|
avivg-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
crates/starknet_os/src/hints/hint_implementation/compiled_class/compiled_class_test.rs line 318 at r5 (raw file):
&contract_class.get_bytecode_segment_lengths(), &contract_class.bytecode, ));
alternative approach:
Suggestion:
fn test_compiled_class_hash_resources_estimation() {
// TODO(Aviv): Parameterize this test to run for both V1 and V2.
let hash_version = HashVersion::V1;
let feature_contract =
FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm));
let class = feature_contract.get_class();
let (mut casm, compiled_class_v1) = match class {
ContractClass::V1(class) => {
let (casm, _sierra_version) = class.clone();
let compiled_class_v1: CompiledClassV1 = class.try_into().unwrap();
(casm, compiled_class_v1)
}
_ => panic!("Expected ContractClass::V1"),
};
// TODO(Aviv): Remove this once we estimate correctly compiled class hash with entry-points.
contract_class.entry_points_by_type = Default::default();
// Run the compiled class hash entry point with full contract loading.
let (mut actual_execution_resources, _hash_computed_by_cairo) =
run_compiled_class_hash_entry_point(&contract_class, true, &hash_version);
// Compare the actual execution resources with the estimation with some allowed margin.
let mut execution_resources_estimation =
estimate_casm_poseidon_hash_computation_resources(compiled_class_v1.bytecode_segment_felt_sizes());ceb85ba to
b0f69ca
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

No description provided.