blockifier: add disallow casm hash v1 declare falg to VC #8889
Conversation
|
This change is |
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
meship-starkware
force-pushed
the
meship/add_disallow_casm_hash_v1_declare_falg_to_vc
branch
from
f50c284 to
95ef7f1
Compare
AvivYossef-starkware
left a comment
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)
noaov1
left a comment
noaov1
left a comment
There was a problem hiding this comment.
@noaov1 reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/resources/blockifier_versioned_constants_0_13_0.json line 29 at r2 (raw file):
"enable_reverts": false, "enable_casm_hash_migration": false, "disallow_casm_hash_v1_declares": false,
WDYT?
Suggestion:
"block_casm_hash_v1_declares": true,
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
crates/blockifier/resources/blockifier_versioned_constants_0_13_0.json line 29 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
WDYT?
Just making sure this is a name change without a meaning change. What I mean by that is it's still false for all older versions and true from 0.14.1 and on
meship-starkware
force-pushed
the
meship/add_disallow_casm_hash_v1_declare_falg_to_vc
branch
from
95ef7f1 to
a33229e
Compare
AvivYossef-starkware
left a comment
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware reviewed 12 of 12 files at r3, all commit messages.
Reviewable status:
No description provided.