-
Notifications
You must be signed in to change notification settings - Fork 64
scripts: add an abstraction for the args that depend on each other and validate them in one place #9797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10-28-scripts_fix_a_bug_where_the_get_pod_names_did_not_use_the_namespace_and_context_from_args
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)
scripts/prod/update_config_and_restart_nodes_lib.py line 600 at r1 (raw file):
for index, config in enumerate(configs): print(f"Applying config {index}...") # apply_configmap(
This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out
scripts/prod/update_config_and_restart_nodes_lib.py line 609 at r1 (raw file):
if restart_strategy != RestartStrategy.NO_RESTART: for index, config in enumerate(configs): # restart_pod(
This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out
35fa0cc to
34281ad
Compare
bb9e648 to
6828d34
Compare
34281ad to
578e5b4
Compare
6828d34 to
f1a3b8b
Compare
578e5b4 to
86d3ec4
Compare
86d3ec4 to
c180da2
Compare
f1a3b8b to
2fc24e1
Compare
c180da2 to
04be961
Compare
…d validate them in one place
04be961 to
8277b17
Compare

No description provided.