Skip to content

Conversation

@guyf-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guyf-starkware commented Oct 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

@guyf-starkware guyf-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)


scripts/prod/update_config_and_restart_nodes_lib.py line 600 at r1 (raw file):

    for index, config in enumerate(configs):
        print(f"Applying config {index}...")
        # apply_configmap(

This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out


scripts/prod/update_config_and_restart_nodes_lib.py line 609 at r1 (raw file):

    if restart_strategy != RestartStrategy.NO_RESTART:
        for index, config in enumerate(configs):
            # restart_pod(

This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out

@guyf-starkware guyf-starkware force-pushed the 10-27-scripts_add_an_abstraction_for_the_args_that_depend_on_each_other_and_validate_them_in_one_place branch from 35fa0cc to 34281ad Compare October 28, 2025 11:07
@guyf-starkware guyf-starkware changed the base branch from main-v0.14.1 to graphite-base/9797 October 28, 2025 11:30
@guyf-starkware guyf-starkware force-pushed the 10-27-scripts_add_an_abstraction_for_the_args_that_depend_on_each_other_and_validate_them_in_one_place branch from 34281ad to 578e5b4 Compare October 28, 2025 11:30
@guyf-starkware guyf-starkware changed the base branch from graphite-base/9797 to 10-28-scripts_fix_a_bug_where_the_get_pod_names_did_not_use_the_namespace_and_context_from_args October 28, 2025 11:30
@guyf-starkware guyf-starkware force-pushed the 10-28-scripts_fix_a_bug_where_the_get_pod_names_did_not_use_the_namespace_and_context_from_args branch from 6828d34 to f1a3b8b Compare October 28, 2025 13:13
@guyf-starkware guyf-starkware force-pushed the 10-27-scripts_add_an_abstraction_for_the_args_that_depend_on_each_other_and_validate_them_in_one_place branch from 578e5b4 to 86d3ec4 Compare October 28, 2025 13:13
@guyf-starkware guyf-starkware force-pushed the 10-27-scripts_add_an_abstraction_for_the_args_that_depend_on_each_other_and_validate_them_in_one_place branch from 86d3ec4 to c180da2 Compare October 30, 2025 11:27
@guyf-starkware guyf-starkware force-pushed the 10-28-scripts_fix_a_bug_where_the_get_pod_names_did_not_use_the_namespace_and_context_from_args branch from f1a3b8b to 2fc24e1 Compare October 30, 2025 11:37
@guyf-starkware guyf-starkware force-pushed the 10-27-scripts_add_an_abstraction_for_the_args_that_depend_on_each_other_and_validate_them_in_one_place branch from c180da2 to 04be961 Compare October 30, 2025 11:37
@guyf-starkware guyf-starkware force-pushed the 10-27-scripts_add_an_abstraction_for_the_args_that_depend_on_each_other_and_validate_them_in_one_place branch from 04be961 to 8277b17 Compare October 30, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants