Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

guy-starkware commented Oct 30, 2025

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):

    // Send message from L1 to L2.
    let l2_contract_address = "0x12";

Extract this to a function


crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):

    // Send message from L1 to L2.
    let l2_contract_address = "0x12";

Move this below the setup

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_tests.rs line 70 at r2 (raw file):

    assert!(message_timestamp > BlockTimestamp(0));

    // Find the L1 event that was posted to Anvil.

Change to // Make sure the L1 event was posted to Anvil

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):

Previously, ShahakShama wrote…

Extract this to a function

Consider putting into that function the "Find the L1 event that was posted to Anvil"

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):

Previously, ShahakShama wrote…

Consider putting into that function the "Find the L1 event that was posted to Anvil"

Looks like great minds think alike (#9909)

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ShahakShama)


crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):

Previously, ShahakShama wrote…

Looks like great minds think alike (#9909)

yeah, slowly building it up.


crates/apollo_l1_provider/tests/flow_tests.rs line 53 at r2 (raw file):

Previously, ShahakShama wrote…

Move this below the setup

Seems like beautifying something that is going to go away on the next PR is a bit of a waste of time (and unnecessary merge conflicts).

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/l1provider/anvil_in_flow_test branch from 14b0114 to a78c5bc Compare November 3, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants