Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "integrated batch inverse in fib cpu (#448)" #477

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

spapinistarkware
Copy link
Collaborator

@spapinistarkware spapinistarkware commented Mar 15, 2024

This reverts commit 3658aa0.


This change is Reviewable

Copy link

graphite-app bot commented Mar 15, 2024

Your org has enabled the Graphite merge queue for merging into dev

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (95612d2) to head (203b0b8).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #477      +/-   ##
==========================================
+ Coverage   94.49%   95.00%   +0.51%     
==========================================
  Files          60       60              
  Lines        9260     9155     -105     
  Branches     9260     9155     -105     
==========================================
- Hits         8750     8698      -52     
+ Misses        458      405      -53     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch from 3c78952 to 806551f Compare March 19, 2024 12:25
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch from 806551f to ad97f40 Compare March 19, 2024 14:01
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch from ad97f40 to 85f3c1f Compare March 19, 2024 14:26
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch from 85f3c1f to d15c754 Compare March 19, 2024 14:38
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch from d15c754 to 7751c2a Compare March 19, 2024 14:48
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch from 7751c2a to 29d8bd8 Compare March 19, 2024 14:52
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch 3 times, most recently from 2b4e4b3 to f2b6222 Compare March 19, 2024 15:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch 3 times, most recently from 3d2e05e to ee96158 Compare March 20, 2024 13:28
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@spapinistarkware spapinistarkware force-pushed the spapini/03-14-FRI_in_Commitment_Scheme branch 2 times, most recently from 178ae68 to 7fa8661 Compare March 21, 2024 07:23
@shaharsamocha7 shaharsamocha7 changed the base branch from spapini/03-14-FRI_in_Commitment_Scheme to dev March 21, 2024 07:27
Copy link
Collaborator Author

spapinistarkware commented Mar 21, 2024

Merge activity

@spapinistarkware spapinistarkware merged commit 9079231 into dev Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants