Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field debug implementations #501

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Mar 17, 2024

This change is Reviewable

Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 94.60%. Comparing base (fc18b4d) to head (25307db).

Files Patch % Lines
src/core/fields/cm31.rs 0.00% 3 Missing and 1 partial ⚠️
src/core/fields/qm31.rs 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           Commitment_scheme_utils     #501      +/-   ##
===========================================================
- Coverage                    94.67%   94.60%   -0.07%     
===========================================================
  Files                           59       59              
  Lines                         8859     8865       +6     
  Branches                      8859     8865       +6     
===========================================================
  Hits                          8387     8387              
- Misses                         423      429       +6     
  Partials                        49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

Copy link
Contributor Author

spapinistarkware commented Mar 19, 2024

Merge activity

@spapinistarkware spapinistarkware changed the base branch from Commitment_scheme_utils to dev March 19, 2024 15:17
@spapinistarkware spapinistarkware merged commit 828bdf3 into dev Mar 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants